Skip to content
This repository was archived by the owner on Oct 9, 2020. It is now read-only.

Benchmarking and Performance Work#324

Open
guybedford wants to merge 5 commits intomasterfrom
perf
Open

Benchmarking and Performance Work#324
guybedford wants to merge 5 commits intomasterfrom
perf

Conversation

@guybedford
Copy link
Member

@guybedford guybedford commented Sep 23, 2015

//cc @harrison @jackfranklin

The first red flag detected in this is that loader reset time is huge, looking into that now.

Sample output:

Simple Build
  Total Time               : 1090ms

Startup
  Total Time               : 96ms

Reset Loader
  Total Time               : 277ms

Deep Trace (first.js)
  Total Time               : 627ms

Trace (10 events)
  Cumulative Time          : 1611ms
  Mean                     : 161.1ms
  Std Deviation            : 209.19ms
  Avg within 2σ            : 26.14ms
  Median                   : 32ms
  Max                      : 559ms (component.jsx!jsx.js)
  Min                      : 10ms (some.js!plugin.js)
  Duplicate Events         : 0
  Total Duplicated Time    : 0ms

Compile Tree (first.js, jquery-cdn, second.js, amd.js, third.js, cjs.js, some.js!plugin.js, global.js, jquery.js, text.txt!text-plugin.js, component.jsx!jsx.js)
  Total Time               : 54ms

Compile (10 events)
  Cumulative Time          : 297ms
  Mean                     : 29.7ms
  Std Deviation            : 10.22ms
  Avg within 2σ            : 31.4ms
  Median                   : 31ms
  Max                      : 46ms (third.js)
  Min                      : 16ms (first.js)
  Duplicate Events         : 0
  Total Duplicated Time    : 0ms

Concatenate
  Total Time               : 21ms

@guybedford
Copy link
Member Author

guybedford commented Sep 23, 2015

When using the build cache, here are the times for the test tree of 10 modules:

Cached Tree Build
  Total Time               : 5ms

Deep Trace (first.js)
  Total Time               : 1ms

Compile Tree (first.js, second.js, amd.js, component.jsx!jsx.js, third.js, cjs.js, global.js, some.js!plugin.js, text.txt!text-plugin.js, jquery.js, jquery-cdn)
  Total Time               : 1ms

Concatenate
  Total Time               : 0ms

This shows that the cache is working pretty well.

@jackfranklin
Copy link

jackfranklin commented Sep 25, 2015

@guybedford this is awesome, thank you so much! Looking forward to running this through our dashboard.

Edit: given our build uses a jspm builder, not "pure" SystemJS/Builder, how can we run this branch? Should we install this branch in node_modules/jspm ? In which case how do we require the profile tool in the build script?

@guybedford guybedford force-pushed the master branch 3 times, most recently from 01b4753 to 88b4b28 Compare May 11, 2016 18:05
@ineentho
Copy link

ineentho commented Aug 31, 2016

Is this something you eventually plan to merge in?

@guybedford guybedford force-pushed the master branch 2 times, most recently from 0171134 to 52ad54c Compare October 16, 2017 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guybedford @jackfranklin @ineentho